Autoupdate replacing a sha with 'older' release
See original GitHub issueI use a pre-commit hook with a rev
pointing to a sha. When I use autoupdate
it changes the rev
to latest release, but that release is older than the previous sha. I think it would make sense not to change the rev if it’s pointing to a commit after the latest release.
Of course, this can be circumvented by passing the other repos to autoupdate but it is a bit cumbersome. I can also update that specific hook using --bleeding-edge
but I don’t really want the latest commit, just the commit where a specific feature is introduced. This might also be useful for pre-commit.ci where AFAIK you cannot specify which repos should be updated.
Just to clarify by older I’m not thinking of dates instead I’m refering to the order they appear in history for the specific branch. I’m not sure if this notion can be generalized across branches.
If you think that it makes sense to implement this and that it can be tackled by someone without much familiarity with the codebase I can try to provide a PR for this.
Issue Analytics
- State:
- Created 3 years ago
- Comments:7 (4 by maintainers)
Top GitHub Comments
I don’t think this really makes sense for pre-commit, you’re essentially asking for
autoupdate --no-autoupdate
which would just be “don’t run autoupdate”.I think for pre-commit.ci, adding a special comment to freeze a version might make sense? but preventing autoupdates actually makes the system less efficient and more expensive (when everything is on the latest versions there’s much less cache data required for oddball versions) so I don’t really want that feature to exist
Even better would be to convince the upstream to make a release with the new feature 😃
yep!