Do version numbers have to have a '.'?

Looking at this line it looks to be testing for the presence of a dot in the version number https://github.com/pre-commit/pre-commit/blob/d827e9aa7211456965bf7d16f06ac6a85b0f2984/pre_commit/clientlib.py#L124 but what if a repo is just following a simple v1/v2 model?

I’m using this repo https://gitlab.salort.eu/jsalort/latexhook/-/tags which has a v1 tag. My .pre-commit-config.yaml looks like this:

repos:
    - repo: https://gitlab.salort.eu/jsalort/latexhook
      rev: v1
      hooks:
          - id: latexindent

This means every time i commit I get this error at the top

My version is pre-commit==2.10.1 and I don’t think this used to happen

[asottile]

yeah so for now I’m going to answer this issue as “yes” – we may revisit if this comes up more frequently

[paulhfischer]

thanks for the issue, you’re correct this warning is new in pre-commit 2.10 (#1715) but shouldn’t be triggered in your case (it’s there to warn when you are pointing to master or HEAD in .pre-commit-config.yaml).

for now (until the detection is improved/updated) you could use the (short) sha the tag points to, in your case 7879fc02.