pre-commit might install flake8 unpinned?

I’m seeing the same version of code pass or fail flake8 checks on different machines. All use the same version of code, same .pre-commit-config.yaml, same version of pre-commit (v1.0.0), and have pinned the same version of flake8 (3.4.1). Some pass flake8 checks, some correctly find an E722:

Tests should end in _test.py.............................................Passed
Flake8...................................................................Failed
hookid: flake8

testing/factories/base_factory.py:123:5: E722 do not use bare except'

@chriskuehl and I think we’ve traced it to pre-commit installing flake8 unpinned on its first attempt, and not updating it later.

Is that enough to work with, or should I try to find more concrete repro steps?

[mittonk]

Great, that gives me some good options.

[asottile]

Or build a mirror for flake8 using pre-commit-mirror-maker – though there’s some outstanding issues until it uses the new types.