nodeenv try to download non existing tar.gz prebuilt under Cygwin
See original GitHub issueHi,
Strange issue: I suspect a recent change broke this as it used to work last week, on another Windows computer with Cygwin.
Bug reproduction: pre-commit run
using e.g. https://github.com/Lucas-C/pre-commit-hooks-html v1.1.0
pre-commit
execute the following command under the hood, a command that also fails if I execute it manually:
nodeenv --prebuilt /cygdrive/c/Users/admin/.pre-commit/repoYHJ85q/node_env-default
The error is the following:
urllib2.HTTPError: HTTP Error 404: Not Found
The tar.gz
it tries to install is https://nodejs.org/dist/v7.2.1/node-v7.2.1-cygwin_nt-6.1-x64.tar.gz, which does not exist. My guess is that nodeenv
should use the Windows prebuilts instead: https://nodejs.org/dist/v7.2.1/node-v7.2.1-win-x64.zip This is because platform.system()
is used: https://github.com/ekalinin/nodeenv/blob/master/nodeenv.py#L503
I’m going to ask for help on the https://github.com/ekalinin/nodeenv project, but do you have any hint at what the root cause could be here ?
Issue Analytics
- State:
- Created 7 years ago
- Comments:8 (8 by maintainers)
Top GitHub Comments
You’re right, I must have mixed up things, it probably never worked.
I think there’s no need to keep this ticket open, I’m tracking this in https://github.com/ekalinin/nodeenv/issues/178
There is still an issue with this. I think I took a shortcut when I tested the previous PR (I must have skipped testing a full repo reinstall), and it definitively still does not work. Sorry about that 😦
This time it is because the
NPM_CONFIG_PREFIX
/npm_config_prefix
env variables must be Windows-like paths for thenpm install -g
to pick the right path with Cygwin.I just sent a PR to fix it: https://github.com/pre-commit/pre-commit/pull/612