question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

rst-directive-colons has type text instead of rst, unlike the other two rst hooks

See original GitHub issue

I’m not if it might be intentional (I don’t see an indication of it), but the rst-directive-colons hook has types: [text] instead of rst like the other two reST hooks. Therefore, if unintentional, false positives might result, and it also doesn’t show up when rst is selected on the pre-commit hooks page (by the way, was that dropdown a relatively new addition or did I just miss it before? Its really nice to have, thanks, and its a further motivation for me to help upgrade older hooks to use types instead of files wherever practicable).

Happy to submit a PR to fix this if it isn’t intended, but I wanted to ask first. Thanks!

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:7 (7 by maintainers)

github_iconTop GitHub Comments

2reactions
asottilecommented, Feb 22, 2021

I think types: [rst] is probably best for now

0reactions
CAM-Gerlachcommented, Feb 23, 2021

Thanks, opened as PR #51

Read more comments on GitHub >

github_iconTop Results From Across the Web

Supported hooks - pre-commit
Exits when it hits the first errored file; php-unit - Run the full php unit test. Checks which PHPUnit executable is available first...
Read more >
Sphinx and RST syntax guide (0.9.3) - Thomas-Cokelaer.info
Restructured Text (reST) and Sphinx CheatSheet¶. Overview. This page describes some of the RST and Sphinx syntax. It is based on resource found...
Read more >
Style - Scikit-HEP
Stub files can be used instead for out-of-line typing. MyPy is suggested for type checking, though there are several other good options to...
Read more >
Writing better Python code, automatically - mje.nz
The new main appears to work normally, but if the config file is not present it fails with UnboundLocalError . Flake8 catches the...
Read more >
Handle an input with React hooks - Stack Overflow
Yes you can handle react hooks with useState() ... return( <> <hr/> <input type="text" placeholder="First Name" onChange={e ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found