createContext has a non-standard (and not used) argument

Reproduction

See create-context.js. The value of the contextId argument appears to be unused. Some compilers, such as Closure error out when migrating. This can normally be ignored, but not clear if it’s justified in this case since the value is unused.

Expected Behavior

The React’s createContext is declared with one argument.

Actual Behavior

The Preact’s createContext is declared with two argument and the value of the second argument is not used.

[JoviDeCroock]

A bundler does no code optimizations so that isn’t really its responsibility (unless you are exclusively talking about a compiler in this case closure). That aside, we could probably resolve this differently, thinking about it atm

[dvoytenko]

Certainly. But I do think “typically not in exported methods” is a good standard to follow. W.r.t. to React compatibility. I agree - it’d certainly make sense to diverge APIs where it has semantic meaning. In this case, however, this is purely an implementation detail. E.g. tomorrow it might disappear from the createContext with no perceptible API difference but would force strict-compiler users to change their code.