Deconstruct props doesn't remove children

Hi,

I found a bug when you deconstruct props, children are not deleted properly.

Here an example: https://codesandbox.io/s/k13proo6ko

in my case it generates a RangeError: Maximum call stack size exceeded.

const MyDiv = ({ children, ...rest }) => {
  console.log(rest);
  return (
    <div {...rest}>
      <div {...rest}>{children}</div>
    </div>
  );
};

Here the rest object still contains the children field. Maybe _objectWithoutPropertiesLoose is not interpreted correctly.

[Kanaye]

No, the property is removed properly. console.log is lazy and prints the objects state after preacts h function modified it. You can observe this behavior by logging rest.children which eveluates to undefined instead of rest example.

[marvinhagemeister]

@Kanaye is right. The issue is caused by us mutating props directly. Looks like we need to clone props in createElement/h.

@jeremycare nah, that’s still an issue and unexpected behaviour. We should fix that 😃