question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`fix className normalization` (#2774) causes regression removing some class names

See original GitHub issue

Hi! I think #2774 is causing a regression, which results in some class names, specifically for Material Icons/RMWC, being removed, and some JS functionality seems broken, too(?). I also verified that reverting to v10.5.2 resolves the regression.

Reproduction

Repo (specific commit): https://github.com/4cm4k1/personal-website/tree/2d4d593ba366b85baa33e05819678491897e776c Deployment (specific commit): https://personal-website-neqqptm34.vercel.app/ Versions:

├── preact@10.5.3
├── preact-render-to-string@5.1.10

Steps to reproduce

  1. Checkout repo at 2d4d593ba366b85baa33e05819678491897e776c
  2. yarn install
  3. yarn dev (exists on prod deployments, too, see above)
  4. Check localhost:3000 (or deployment)

Expected Behavior

Material Icons/RMWC class names are outputted and display properly.

Actual Behavior

Material Icons/RMWC class names are omitted, causing improper display and possibly(?) stops JS.

Thank you!!!

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:6
  • Comments:6 (4 by maintainers)

github_iconTop GitHub Comments

2reactions
marvinhagemeistercommented, Oct 5, 2020

We’ve just published 10.5.4 which includes a fix for this issue. Can’t reproduce it anymore 🎉

1reaction
charrondevcommented, Oct 5, 2020

I ended up just reverting to 10.5.2 in the meantime, which doesn’t seem to have the bug. I guess I must not be fully understanding the initial issue, but 10.5.3 introduces a “fix” for classnames in preact/compat, but from what I can see classnames were working in 10.5.2 and are broken in 10.5.3.

Read more comments on GitHub >

github_iconTop Results From Across the Web

style and className props aren't being correctly reconciled ...
Here's a sample app the reproduces the behavior: ... fix className normalization (#2774) causes regression removing some class names ...
Read more >
material-ui/core/CHANGELOG.md - UNPKG
951, - Fix a class name generation regression (#12844). 952, - And many more bug fixes and documentation improvements .
Read more >
3a2425a5aed1bef93dab954745...
<init> c96e307: fix wrong import 8d4324e: Minor changes: remove ... 95f758b: class name completion in string literals inserts qualified names after imports; ...
Read more >
CHANGELOG.md - TINMAN
Fix a class name generation regression (#12844). - And many more bug fixes and documentation improvements . ### `@material-ui/core@v3.1.0` - [Checkbox] ...
Read more >
Changelog and Migration Guide - Detekt
We fixed a regression introduced in 1.19.0 for users using ... part of class name - #3977; IgnoredReturnValue: fix false negative when annotation...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found