`fix className normalization` (#2774) causes regression removing some class names
See original GitHub issueHi! I think #2774 is causing a regression, which results in some class names, specifically for Material Icons/RMWC, being removed, and some JS functionality seems broken, too(?). I also verified that reverting to v10.5.2 resolves the regression.
Reproduction
Repo (specific commit): https://github.com/4cm4k1/personal-website/tree/2d4d593ba366b85baa33e05819678491897e776c Deployment (specific commit): https://personal-website-neqqptm34.vercel.app/ Versions:
├── preact@10.5.3
├── preact-render-to-string@5.1.10
Steps to reproduce
- Checkout repo at
2d4d593ba366b85baa33e05819678491897e776c
yarn install
yarn dev
(exists on prod deployments, too, see above)- Check
localhost:3000
(or deployment)
Expected Behavior
Material Icons/RMWC class names are outputted and display properly.
Actual Behavior
Material Icons/RMWC class names are omitted, causing improper display and possibly(?) stops JS.
Thank you!!!
Issue Analytics
- State:
- Created 3 years ago
- Reactions:6
- Comments:6 (4 by maintainers)
Top Results From Across the Web
style and className props aren't being correctly reconciled ...
Here's a sample app the reproduces the behavior: ... fix className normalization (#2774) causes regression removing some class names ...
Read more >material-ui/core/CHANGELOG.md - UNPKG
951, - Fix a class name generation regression (#12844). 952, - And many more bug fixes and documentation improvements .
Read more >3a2425a5aed1bef93dab954745...
<init> c96e307: fix wrong import 8d4324e: Minor changes: remove ... 95f758b: class name completion in string literals inserts qualified names after imports; ...
Read more >CHANGELOG.md - TINMAN
Fix a class name generation regression (#12844). - And many more bug fixes and documentation improvements . ### `@material-ui/core@v3.1.0` - [Checkbox] ...
Read more >Changelog and Migration Guide - Detekt
We fixed a regression introduced in 1.19.0 for users using ... part of class name - #3977; IgnoredReturnValue: fix false negative when annotation...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
We’ve just published
10.5.4
which includes a fix for this issue. Can’t reproduce it anymore 🎉I ended up just reverting to 10.5.2 in the meantime, which doesn’t seem to have the bug. I guess I must not be fully understanding the initial issue, but 10.5.3 introduces a “fix” for classnames in
preact/compat
, but from what I can see classnames were working in 10.5.2 and are broken in 10.5.3.