Using createPortal and Router causes route to be removed

Not too sure if this belongs more here or on preact-router. But I was investigating a strange behaviour in my app that I’m slowly moving from 8.4.2 to X.

I made a codesandbox that illustrates the issue.

It seems as that when you call createPortal in a router path, it renders the contents of the portal, but removes everything else.

I would expect it to render into the defined element, either at the beginning or the end, but it seems to replace everything.

If this should be moved to preact-router I can move it there.

[JoviDeCroock]

This is a bug, when using createPortal it overrides the full given node instead of inserting before already existing elements.

I have tested it with a minimal example and it is.

Most minimal example to test with:

const App = () => (
  <div>
    <p>hello</p>
    {createPortal(<div>Portalled</div>, document.getElementById("root"))}
  </div>
);

render(<App />, document.getElementById("root"));

This will effectively remove <p>Hello</p> from root

[pmkroeker]

I’ll reopen this until there is as definite answer, document.body works but document.querySelector(#root) does not when used with preact-router