Imports in documentation for Signals

I noticed a possible minor issue with the documentation for Signals.

In some examples on the page, imports look like this:

import { signal, computed } from "@preact/signals";

In some later examples on the same page, instead imports look like this:

import { signal, computed, effect } from "@preact/signals-core";

The switch from @preact/signals to @preact/signals-core doesn’t seem to be explained in the text.

Presumably @preact/signals-core is the stuff that’s generic and shared with the React implementation?

And @preact/signals is the Preact-specific implementation?

So I’m not grasping why you would switch between these in the examples.

(note also that @preact/signals-core was published without a README.)

[rschristian]

Perhaps that’s some poor naming, indeed. I’m not a huge fan of splitting up the content (we don’t really do that for any other topic) but maybe that’s what we need to do.

There’s also the question of whether signals-core should be covered in Preact’s docs at all (from the Preact team, but not necessarily relevant to someone looking to use Preact + its addons) but I don’t have a great answer for that at the moment either.

Will definitely be thinking about this though, maybe there’s a way to restructure some of our content that’ll fit this sort of situation better. I think our current set up does make it a bit difficult to differentiate what’s from the team and what’s meant to be used with Preact itself.

[mindplay-dk]

Okay, that’s a bit confusing. But yes, I understand now that these examples are not in fact about Preact - they’re about using Signals independently of Preact.

Perhaps this section should be migrated to a separate page under “Advanced”? With a link from where it is now.

The title “Advanced signals usage” does make it seem out of place in the “Essentials” section, I think.