Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Mapping SKIPed Task Runs Bug

See original GitHub issue

Opened from the Prefect Public Slack Community

michael.ludwig: This is how we apply map:

bucket_prefix = create_bucket_prefix_rfy()
prediction_single_files = list_files(s3_folder=prediction)
return load_rfy.map(
    input_data_location=prediction_single_files,
    bucket_prefix=unmapped(bucket_prefix),
)

michael.ludwig: We have a custom trigger but maybe something is broken with that guy when working with “Mapped” states:

def _trigger(self, upstream_states: Dict[Edge, State]) -&gt; bool:
        partition = self.check_partition()
        self.log_info(f"partition exists: {partition.exists}")
        if (
            trigger_run(
                list(upstream_states.values()),
                self._ignore_upstream_success_states_for_triggering,
            )
            or not partition.exists
        ):
            self.log_info(f"Triggering {self._name}")
            return True

        self._revision = cast(str, partition.revision)

        skip_message = (
            f"Partition already exists. Using most recent revision: {self._revision}"
        )
        self.log_info(skip_message)
        self.log_info(f"Skipping {self._name}")
        raise SKIP(result=self.get_output(), message=skip_message)

def trigger_run(
    upstream_states: Sequence[state.State],
    ignore_upstream_success_states_for_triggering: bool,
) -&gt; bool:
    n_upstream_states = len(upstream_states)
    n_success = sum(1 for task_state in upstream_states if task_state.is_successful())

    # If any task before had a different state than success or skip, don't run.
    if n_success &lt; n_upstream_states:
        raise TRIGGERFAIL(
            'Trigger was "all_successful" but some of the upstream tasks failed.'
        )

    # Don't run this task based on upstream state only
    if ignore_upstream_success_states_for_triggering:
        return False

    n_skipped = sum(1 for task_state in upstream_states if task_state.is_skipped())

    # If the number of skipped states were less then the total number of states, run.
    return n_skipped &lt; n_upstream_states

znicholasbrown: Hi <@U016C6EMJ6P> - this looks like you may have found a bug; would you please open an issue with your reproduction here and some minimum input data so we can reproduce?

dylan: <@ULVA73B9P> open “Mapping SKIPed Task Runs Bug”

Original thread can be found here.