question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

PIN 16: Add `Result` subclasses corresponding to all current result handlers

See original GitHub issue

Use Case

Blocked by #2139. See PIN 16 (PR #2134) for background.

Solution

Implement a Result subclass for each of the current result handlers that knows how to .read, write, and check if it .exists:

  • AzureResultHandler
  • GCSResultHandler
  • LocalResultHandler
  • S3ResultHandler
  • SecretResultHandler
  • JSONResultHandler

Please do not implement ConstantResultHandler as part of this ticket as it will be handled separately in #2145.

Alternatives

Please describe any alternatives you’ve considered, even if you’ve dismissed them

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:6 (2 by maintainers)

github_iconTop GitHub Comments

1reaction
cicdwcommented, Mar 13, 2020

@wagoodman I think we should go with option 2 to avoid maintaining weird multi-class interactions - if we want to deprecate result handlers then I don’t think we should be using them in a first class way within our codebase. Instead, we can autoconvert result handlers passed to tasks into the corresponding Result instance.

In terms of timeline, I propose that 0.12.0 can include the removal of ResultHandlers.

1reaction
lauralorenzcommented, Mar 13, 2020

Looks like #2139 is officially closed so we are in the clear, and I assigned this to you @wagoodman for realsies if you are still in

Read more comments on GitHub >

github_iconTop Results From Across the Web

Activity | Android Developers
There are two methods almost all subclasses of Activity will implement: ... BiometricManager for handling biometric and PIN/pattern/password authentication.
Read more >
Class Definition for Class 705 - DATA PROCESSING - USPTO
SECTION I - CLASS DEFINITION. This is the generic class for apparatus and corresponding methods for performing data processing operations, in which there...
Read more >
fx-991EX fx-570EX - User's Guide - Support - CASIO
The display currently shows an intermediate result of a multi- statement calculation.. This indicator is displayed while the calculator is being.
Read more >
1. General Guidance for Processing Correspondence
The following systems are used to generate VBA correspondence letters to clients, which the list may not be all inclusive:.
Read more >
Position Classification Standard for Support Services ... - OPM
This series includes all positions the primary duties of which involve supervising, directing, or planning and coordinating a variety of services functions ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found