feat(query): clearing data after unset listener

Do you want to request a feature or report a bug?
bug

What is the current behavior? If i want to change a document listener to another id, then previous data is still existing until new data is received.

What is the expected behavior? After removing the listener, the data connected to that listener should be removed.

Which versions of dependencies, and which browser are affected by this issue? Did this work in previous versions or setups? Newest

Steps to reproduce and if possible a minimal demo of the problem via codesandbox or similar.

[
    {
        collection: 'collections',
        doc: props.collectionId,  // data from my reducer. If this id is changed then previous data is still existing
        storeAs: 'collection'
    }
]

[esbenvb]

I agree with @apietrzak - of course we can store the data with a custom-made key for each document, but that will not only make the app a bit code more complex, it also leads to memory leaks, when the user is browsing around in 100s or 1000s of pages in the app, all these are kept in the store, because they were once loaded.

I don’t see any solutions that are more elegant than the removeOnUnset: true option suggested.

[apietrzak]

@prescottprue I understand it, but still, i don’t need that data in the store if a listener was removed. For example: A user iterates over 100 collections, then it’s taking 100 entries in the store.

Listener config:
[
    {
        collection: 'collections',
        doc: props.collectionId,
    }
]

State:
collections: {
    collectionID1: {...}
}

Actions:
UNSET_LISTENER
SET_LISTENER
LISTENER_RESPONSE

New state:
collections: {
   collectionID1: {...},   // I don't need that
   collectionID2: {...}
}

Additionaly, when the user backs to the first collection then in the store is still old data and will be refreshed soon, which means the user will see old view of my appliaction instead of loading screen. In my case, there will be better to remove that data and load it one more time if needed. For example by adding argument to listener config:

[
   {
        collection: 'collections',
        doc: props.collectionId,
        removeOnUnset: true
   }
]