Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

feat(reducers): switch ordered to be just be keys instead of objects

See original GitHub issue

I am not a 100% on this one, but I can’t immediately see why the same data is repeated between the firestore.data and firestore.ordered. This essentially doubles the size of the store and I can see how this becomes problematic for large apps with large documents if I want to persist state in localstorage.

Wouldn’t it be enough for firestore.ordered to be simply an array of IDs so that I know the order of IDs and then get the data from the firestore.data key?

Issue Analytics

State:
Created 4 years ago
Reactions:2
Comments:5 (4 by maintainers)

Top GitHub Comments

3reactions

prescottpruecommented, Apr 21, 2019

Yeah like I said, I agree that it is best practice to keep just the keys in the array, and that is what I use with other APIs anyways, so lets switch this to a ticket for capturing that. As always, I’m open to PRs if you get a chance to work on it.

Really glad to have folks giving input on the core architecture, especially on redux-firestore since it is still so young. Thanks for reaching out!

1reaction

prescottpruecommented, Dec 4, 2019

@illuminist In v1 the all subcollections are stored at the top level with the path in state including the name of the subcollection. With that in mind, all of the ordered state should just be a single level with different arrays of keys regardless of what level the in the collection/subcollection tree then data lives

Top Results From Across the Web

Refactoring Reducers Example | Redux

Let's look at a demonstration of how a large single reducer function can be refactored into a composition of several smaller functions. Note: ......

React-Redux: Combining reducers: Unexpected Keys

Expected to find one of the known reducer keys instead: "events", "flash". Unexpected keys will be ignored. My initial state is passed in...

Understanding the magic behind StoreModule of NgRx ...

We'll examine how state, reducers, store and actions work with each other and ... initialState)) will combine all the reducers into one object,...

Redux Toolkit Combine Slices - polley-design

combineReducers takes an object full of slice reducer functions, and creates a function that outputs a corresponding state object with the same keys....

Learn mapStateToProps & Connect API - Frontend Masters

Steve demonstrates how to use mapStateToProps and reducers to pull and map objects from the Redux store instead of having a hard coded...