presto-verifier-0.263.1-executable.jar broken

Downloaded the jar from https://prestodb.io/docs/current/admin/verifier.html and followed the instruction to rename and chmod.

$ ./verifier
Error: Invalid or corrupt jarfile ./verifier

The 0.245 version was known to work:

$ java -jar ./presto-verifier-0.245-SNAPSHOT-executable.jar
usage: verifier <command> [<args>]

The most commonly used verifier commands are:
    help     Display help information
    verify   verify

The problem happened between (0.245, 0.259]. I didn’t test all versions in between.

[ajaygeorge]

@arunthirupathi I’m ok with the simple jar approach.

[ajaygeorge]

@arunthirupathi that is a great find. This got me curious as to why presto-verifier should be using fastutil dependency in the first place since there is no apparent need for it. To test, I added the dependency exclusion for presto-main from where this transitive dependency is pulled in to presto-verifier’s pom.xml

        <dependency>
            <groupId>com.facebook.presto</groupId>
            <artifactId>presto-main</artifactId>
            <exclusions>
                <exclusion>
                    <groupId>it.unimi.dsi</groupId>
                    <artifactId>fastutil</artifactId>
                </exclusion>
            </exclusions>
        </dependency>

I was able to compile and generate the jar and it yields the working jar and as expected we are around 12k classes down. So were just un-necessarily pulling in transitive dependencies that are not needed.

10:31 $ jar tvf target/presto-verifier-0.265-SNAPSHOT-executable.jar | wc -l
   54540

I think adding the exclusion can be a good short term solution and the long term solution could be spinning out the metadata package (which looks like the main dependency) from presto-main as a separate module.

@rongrong / @tdcmeehan WDYT ?