Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Comments not emitted in chaining calls

See original GitHub issue

before:

request
  .post('/version')  // comment 1
  .set('Prefer', 'plurality=singular') /* comment 2 */
  .send()
  .end((error, response) => {});

after:

request
  .post('/version')
  .set('Prefer', 'plurality=singular')
  .send()
  .end((error, response) => {});

Issue Analytics

State:
Created 7 years ago
Reactions:2
Comments:8 (7 by maintainers)

Top GitHub Comments

2reactions

vjeuxcommented, Jan 29, 2017

Thanks @dmnd, this is a known issue and there’s a fix in https://github.com/jlongster/prettier/pull/469

Also, awesome job on dedent package, it makes template literals usable!

1reaction

vjeuxcommented, Jan 31, 2017

@amasad for this, I have a fix that I need to properly extract out before we can release it. I want it in before I do the next release

diff --git a/src/comments.js b/src/comments.js
index e05c7f5..d31122e 100644
--- a/src/comments.js
+++ b/src/comments.js
@@ -152,7 +152,10 @@ function attach(comments, ast, text) {
       // If a comment exists on its own line, prefer a leading comment.
       // We also need to check if it's the first line of the file.

-      if (followingNode) {
+      if (enclosingNode.type === "MemberExpression" &&
+          followingNode.type === "Identifier") {
+        addLeadingComment(enclosingNode, comment);
+      } else if (followingNode) {
         // Always a leading comment.
         addLeadingComment(followingNode, comment);
       } else if (precedingNode) {