Consistently add quotes to object keys

While running through the codebase, prettier happens to conflict with the eslint quote props “consistent-as-needed” ( http://eslint.org/docs/rules/quote-props ):

const request = {
  method: 'GET',
  headers: {
    'Accept': 'application/json', // Accept isn't quoted right now
    'Content-Type': 'application/json',
  },
}

Apparently we are now doing “as-needed”. The difference is that if one element in an object has quotes, then all of them must.

Given those two examples, it sounds like this is a better way to add quotes, but I wanted to get some feedback before implementing it.

[oliversturm]

@felixfbecker FWIW, I don’t agree - I think it’s perfectly fine just like that.

[felixfbecker]

This is very annoying, we have this all over our codebase for OpenTracing:

span.log({
    event: 'error',
    'error.object': err,
    message: err.message,
    stack: err.stack,
})

And for HTTP header hashes and CSS styles it’s very common too.

Everyone I know agrees that quoting the keys consistently makes the code more readable