Direct from github installs don’t work with the default .yarnclean

Hey there, I’m trying to use prettier@next so my team can go ahead and start using the new 3.7 syntactical features. I noticed the PR landed and the versions page says to run yarn add prettier/prettier, which is a direct from GH installation, and I did. I’m getting this error:

    🕘 17:36:54 ⎦📘 ~/projects/payment-plugin-3 🌱 development (3/755) ⎡
 📒3147 💩 yarn lint:ts
yarn run v1.17.3
$ eslint modules --ext ts,tsx
Error: Cannot find module '../doc'
Require stack:
- /Users/edrapkin/projects/payment-plugin-3/node_modules/prettier/src/main/comments.js
- /Users/edrapkin/projects/payment-plugin-3/node_modules/prettier/src/main/core.js
- /Users/edrapkin/projects/payment-plugin-3/node_modules/prettier/src/index.js
- /Users/edrapkin/projects/payment-plugin-3/node_modules/prettier/index.js
- /Users/edrapkin/projects/payment-plugin-3/node_modules/eslint-plugin-prettier/eslint-plugin-prettier.js
- /Users/edrapkin/projects/payment-plugin-3/node_modules/eslint/lib/cli-engine/config-array-factory.js
- /Users/edrapkin/projects/payment-plugin-3/node_modules/eslint/lib/cli-engine/cascading-config-array-factory.js
- /Users/edrapkin/projects/payment-plugin-3/node_modules/eslint/lib/cli-engine/cli-engine.js
- /Users/edrapkin/projects/payment-plugin-3/node_modules/eslint/lib/cli-engine/index.js
- /Users/edrapkin/projects/payment-plugin-3/node_modules/eslint/lib/cli.js
- /Users/edrapkin/projects/payment-plugin-3/node_modules/eslint/bin/eslint.js
Occurred while linting /Users/edrapkin/projects/payment-plugin-3/modules/common/src/TestUtils.tsx:1
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:610:15)
    at Function.Module._load (internal/modules/cjs/loader.js:526:27)
    at Module.require (internal/modules/cjs/loader.js:666:19)
    at require (/Users/edrapkin/projects/payment-plugin-3/node_modules/eslint/node_modules/v8-compile-cache/v8-compile-cache.js:161:20)
    at Object.<anonymous> (/Users/edrapkin/projects/payment-plugin-3/node_modules/prettier/src/main/comments.js:12:5)
    at Module._compile (/Users/edrapkin/projects/payment-plugin-3/node_modules/eslint/node_modules/v8-compile-cache/v8-compile-cache.js:194:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:770:10)
    at Module.load (internal/modules/cjs/loader.js:628:32)
    at Function.Module._load (internal/modules/cjs/loader.js:555:12)
    at Module.require (internal/modules/cjs/loader.js:666:19)
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

[lydell]

So … I initially labeled this as “bug” but this has been the case since 2017-12-26 and nobody has noticed anything until now. And the yarn autoclean docs say:

Note: This command is considered for advanced use cases only.

[…]

Autoclean functionality is disabled by default.

It is highly recommended that you manually review the default entries in .yarnclean and customize them to fit your needs.

So this does sound more like a user error than an error on our side. On the other hand, if it’s easy to fix this on our side then why not 🤷‍♂

[EdwardDrapkin]

EDIT: nvm, this package doesn’t include a .yarnclean, it’s my top level one doing it. My bad.