Is always attempting to format node_modules

even when I try explicitly ignoring the folder

scripts: {
    "format": "prettier-eslint \"./**/*.js\" --ignore \"./node_modules/**\" --write"
}

[dlindahl]

I am also running into this issue. An initial poke at the source code seems to indicate that prettier-eslint-cli is honoring the .eslintignore file that is shipped with installed NPM modules. I added some console.infos inside isFilePathMatchedByEslintignore, just before the return, and here is a snippet of the output:

eslintignorePath /Users/dlindahl/Work/website/.eslintignore
eslintignoreDir /Users/dlindahl/Work/website
isIgnored? node_modules/fsevents/node_modules/punycode/punycode.js true
---
eslintignorePath /Users/dlindahl/Work/website/node_modules/fsevents/node_modules/qs/.eslintignore
eslintignoreDir /Users/dlindahl/Work/website/node_modules/fsevents/node_modules/qs
isIgnored? dist/qs.js true
---
eslintignorePath /Users/dlindahl/Work/website/node_modules/fsevents/node_modules/qs/.eslintignore
eslintignoreDir /Users/dlindahl/Work/website/node_modules/fsevents/node_modules/qs
isIgnored? lib/formats.js false

You can see when the parser is looping through punycode, it is using the project .eslintignore. But when its looping throug fsevents, it picks up the .eslintignore file contained in the fsevents module which is configured only to ignore its own dist directory.

Because fsevents isn’t ignoring node_modules on its own, prettier-eslint-cli starts to process all of the dependencies of fsevents.

I want to say that the way prettier-eslint-cli treats nested .eslintignore paths seems like a bug to me. I would think that the project settings should trump anything nested within it. Is this the expected behavior?

[kentcdodds]

It’s unclear this is an issue with the package. Feel free to investigate further.