prettier-eslint doesn't respect prettier default

from inferring prettierOptions via eslintConfig:

Defaults if you have all of the relevant ESLint rules disabled (or have ESLint disabled entirely via /* eslint-disable */ then prettier options will fall back to the prettier defaults:

{
  trailingComma: 'none',
}

Prettier Trailing Commas:

Default value changed from none to es5 in v2.0.0 “es5” - Trailing commas where valid in ES5 (objects, arrays, etc.)

As a result, When I save my file, prettier-eslint removes a trailing commas, and when I git commit my code, the pre-commit prettier hook fails and re-add the trailing comma.

Fixed by adding .prettierrc:

trailingComma: "es5"

It took me a while to figure out, just because I assumed the plugin respected prettier’s default.

[kylemh]

To explain: it did and we fully intend on doing so again.

Prettier changed the defaults and we just never updated it here.

Should be a very simple PR!

[JounQin]

close in favor of #334