leading chained method does not indent

const create = (
  queue: AWS.SQS,
  queueSettings: AWS.SQS.ReceiveMessageRequest,
): Most.Stream<Job> =>
  Most.periodic(secondsToMilliseconds(queueSettings.WaitTimeSeconds))
    .map(() => pull(queue, queueSettings))
    .await()
    .concatMap(({ Messages }: AWS.SQS.ReceiveMessageResult) =>
      Most.from(Messages.map(parseMessage).map(createJob)),
    )
    .multicast()

Would read better as:

const create = (
  queue: AWS.SQS,
  queueSettings: AWS.SQS.ReceiveMessageRequest,
): Most.Stream<Job> =>
  Most
    .periodic(secondsToMilliseconds(queueSettings.WaitTimeSeconds))
    .map(() => pull(queue, queueSettings))
    .await()
    .concatMap(({ Messages }: AWS.SQS.ReceiveMessageResult) =>
      Most.from(Messages.map(parseMessage).map(createJob)),
    )
    .multicast()

[jasonkuhrt]

Warning: Bike Sheds Ahead

Because this looks funny:

Promise
  .resolve()
  .then(something)
  .then(somethingElse);

^ IMHO looks great to me. It is a computational pipeline along the lines of functional composition, I don’t see anything silly here personally.

Rx.Observable.fromEvent(someElement, "click")
  .throttle(200)
  .subscribe(doSomething);

^ IMHO worse than silly this is just plain harder to read. Personally I would write this as:

Rx
  .Observable
  .fromEvent(someElement, "click")
  .throttle(200)
  .subscribe(doSomething);

Which once again captures the functional pipeline nature (and some namespace access, fine) and is easy on the eyes because incremental steps follow along a single dimension.

_
  .chain(matrix)
  .flatMap(foo)
  .reduce(add)
  .value();

^ Silly because _ is not a great identifier. Use almost anything else and its fine. F or L or whatever.

[jasonkuhrt]

@vjeux clear! Thanks