[Prettier API] crashing in printJSXChildren with custom parser and JSX whitespace

I’m trying to avoid parsing some text again after generating the AST with babylon, so I’m using this code to return the ast directly in parsing:

https://runkit.com/darknoon/5a9ef2674d0ffc001297fd53

It works for most cases, but if there is a JSX element with extra whitespace, I get this exception:

TypeError: Cannot read property 'split' of undefined

You can see the full exception on the runkit above.

Input:

const var = <A>  </A>;

Output: throws a TypeError

[duailibe]

@darknoon Actually it did fix the issue

 FAIL  test/editXCoord.test.js
  ✓ find first comment in canvas (14ms)
  ✕ output with no change is same as input (37ms)
  ✕ change value of x to x+1 (27ms)

The "output with no change is same as input" test fails because Prettier looks at the original code to detect newlines, but you don’t pass anything there:

https://github.com/darknoon/auto-code-react/blob/17000d735ee212524fb759cf009398452a309dd8/test/editXCoord.test.js#L55-L60

If you change prettier.format('', { to prettier.format(text, {, that test now passes:

 FAIL  test/editXCoord.test.js
  ✓ find first comment in canvas (18ms)
  ✓ output with no change is same as input (37ms)
  ✕ change value of x to x+1 (28ms)

Now the "change value of x to x+1" is the only one failing and inspecting that, it’s because you change the expression of an expression container in

https://github.com/darknoon/auto-code-react/blob/17000d735ee212524fb759cf009398452a309dd8/test/editXCoord.test.js#L92-L94

If you print the before/after of that NumericLiteral what you get is:

// before
    Node {
      type: 'NumericLiteral',
      start: 277,
      end: 278,
      loc: 
       SourceLocation {
         start: Position { line: 17, column: 16 },
         end: Position { line: 17, column: 17 } },
      extra: { rawValue: 0, raw: '0' },
      value: 0 }

// after
    { type: 'NumericLiteral', value: 1 }

If you check how Prettier prints NumericLiterals, you see it relies on node.extra.raw:

https://github.com/prettier/prettier/blob/f6f6f2e2eaa8d784ddb54e9219416e37cc3b94ec/src/language-js/printer-estree.js#L1309-L1310

[darknoon]

@duailibe thanks for your help!