question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

ESLint integration: `.eslintignore` is not honoured

See original GitHub issue

When I use the prettier-eslint CLI or via the Node API, I can see that when a file is ignored by ESLint via .eslintignore, it gets formatted with Prettier but ESLint auto fixes do not apply afterwards. This is as expected.

However, when I try the same via this extension, the ESLint auto fixes are applied. This is not expected.

I believe this might be related to the fact that the prettier-eslint Node module is the one bundled with the package: when I invoke prettier-eslint from inside the folder containing the .eslintignore, it is honoured, but I invoke it from a folder outside (such as is the case with this extension), it is not honoured.

This might be an upstream bug, but filing here for reference. What do you think?

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:6 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
john-griffincommented, Oct 17, 2018

Just hit this too.

0reactions
github-actions[bot]commented, Apr 12, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Ignoring Code - ESLint - Pluggable JavaScript Linter
A pluggable and configurable linter tool for identifying and reporting on patterns in JavaScript. Maintain your code quality with ease.
Read more >
ESLint --ignore-pattern is not working if file .eslintignore is not ...
ESLint --ignore-pattern is not working if file .eslintignore is not exists · Go to Settings -> Languages & Frameworks -> JavaScript -> Code...
Read more >
ESLint not working in VS Code? - Stack Overflow
If ESLint is running in the terminal but not inside VSCode, it is probably because the extension is unable to detect both the...
Read more >
ESLint not working in VSCode? Help build a troubleshooting ...
Most issues I even encounter... Tagged with eslint, webdev, linting, vscode. ... Are you having trouble with the TypeScript integration?
Read more >
Linting in TypeScript using ESLint and Prettier - LogRocket Blog
Integrate Prettier with ESLint to automate type-checking in your TypeScript code and ensure that the code has no bugs.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found