formatOnSave not firing

Like #440, #441, and others, I too am having issues with Prettier after the 1.23.0 update, but slightly different. If I use the > Format Document from the command panel dropdown, it works, but it doesn’t format on save anymore.

I have looked through the different logs in Output tab, but don’t see anything that seems to be an error.

In my vscode settings I have only these settings with nothing else

{
    "editor.formatOnSave": false,
    "[javascript]": {
        "editor.formatOnSave": true
    }
}

As (mostly) seen in this screen shot, I have all my extensions, except this one, disabled.

[kyledetella]

I was having a similar problem with .tsx files. @kyleknighted’s fix worked for me (with a slight tweak):

"[typescriptreact]": {
  "editor.formatOnSave": true
},

[kyleknighted]

Looks like adding

"[javascriptreact]": {
    "editor.formatOnSave": true
},

appears to fix the issue. I didn’t realize VSCode differentiated between the two. I’ve got my plugins enabled and everything appears to be working again. I’m curious as to how it worked before without this specific language, but I guess as long as it works now… 😃

Thanks for helping me debug. Closing the issue.