question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Prettier ESLint should be invoked for TypeScript files

See original GitHub issue

ESLint supports TypeScript files through typescript-eslint-parser.

However, when eslintIntegration is enabled, this extension will silently skip prettier-eslint for TypeScript files: https://github.com/prettier/prettier-vscode/blob/7431dd3dc8c0e324be98378efcd1a90ce4f547fa/src/PrettierEditProvider.ts#L118

Are you happy for me to raise a PR that changes this, so TypeScript files do run through prettier-eslint?

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:8 (5 by maintainers)

github_iconTop GitHub Comments

2reactions
OliverJAshcommented, Aug 29, 2017

Any updates on this? My team is having to manually apply this patch on every update.

1reaction
jasperjncommented, Sep 4, 2017

prettier-eslint supports ts files with typescript-eslint-parser since v7.1.0.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Prettier, ESLint and Typescript - DEV Community ‍ ‍
Let's create a file called index.js with the following code: // index.js const a = 1. If we run npx prettier index.js ,...
Read more >
Linting in TypeScript using ESLint and Prettier - LogRocket Blog
Integrate Prettier with ESLint to automate type-checking in your TypeScript code and ensure that the code has no bugs.
Read more >
How to use Prettier with ESLint and TypeScript in VSCode
In this guide, we'll explain how to use Prettier with ESLint, delegating the responsibility of code convention definition to ESLint, ...
Read more >
Using ESLint and Prettier in a TypeScript Project
A useful command to add to the package.json scripts is a lint command that will run ESLint. ... The above script can be...
Read more >
Prettier, ESLint and Typescript - LinkedIn
Let's create a file called index.js with the following code: // index.js const a = 1. If we run npx prettier index.js, the...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found