question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Regression: Semicolons setting is ignored

See original GitHub issue

You must complete all steps in this checklist or the issue will be automatically closed.

  • Write a summary of your issue
  • Include a link to a github repo that can be used to reproduce the issue or exact reproduction steps.
  • Provide the expected result
  • Provide the actual result
  • Include extension, os, and vs code information
  • Include Prettier extension log

Summary

Regresion from version 3.7.0, when I downgrade plugin, the option is honored and working as expected

Github Repository to Reproduce Issue

No need, open any TypeScript file and observe the inserion of semicolons.

also I use "editor.formatOnSave": true, but seems unrelated

Steps To Reproduce:

  1. set "prettier.semi": false, in ~/.config/Code - OSS/User/settings.json
  2. Start vscode and open any Typescript file,
  3. remove or make sure you don’t terminate lines with semicolons

Expected result

Honor the "prettier.semi": false, config option and do not add semicolons

Actual result

The prettier see the semi config option being false but ignores it and put semicolons as if I set it to true

Additional information

This is a regression from 3.7.0 version of this plugin

It is similar issue as #1085

VS Code Version: 1.40.0-3

Prettier Extension Version: 3.8.0

OS and version: 5.3.12-1-MANJARO && Windows 10 1803

Prettier Log Output

[INFO - 3:44:39 PM] Formatting /home/frdm/src/webserver-ui/frontend/src/app/app.module.ts.
[INFO - 3:44:39 PM] Using bundled version of prettier.
[INFO - 3:44:39 PM] Resolved ignore file to /home/frdm/src/webserver-ui/frontend/.prettierignore.
[INFO - 3:44:39 PM] File Info:
{
  "ignored": false,
  "inferredParser": "typescript"
}
[INFO - 3:44:39 PM] Prettier Options:
{
  "arrowParens": "avoid",
  "bracketSpacing": true,
  "endOfLine": "auto",
  "htmlWhitespaceSensitivity": "css",
  "insertPragma": false,
  "jsxBracketSameLine": false,
  "jsxSingleQuote": false,
  "printWidth": 80,
  "proseWrap": "preserve",
  "quoteProps": "as-needed",
  "requirePragma": false,
  "semi": false,
  "singleQuote": true,
  "tabWidth": 2,
  "trailingComma": "none",
  "useTabs": false,
  "vueIndentScriptAndStyle": false,
  "filepath": "/home/frdm/src/webserver-ui/frontend/src/app/app.module.ts",
  "parser": "typescript"
}
[INFO - 3:44:40 PM] Formatting completed in 104.164077ms.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:6 (2 by maintainers)

github_iconTop GitHub Comments

2reactions
ntottencommented, Nov 25, 2019

@freed00m add a prettier config file to the project.

1reaction
ntottencommented, Nov 22, 2019

Sorry, the bot closed this issue by mistake. I had a typo in the config of the bot. But yes, this is by design.

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to remove semicolons in prettier? - Stack Overflow
I am using the VS Code prettier plugin to format my code, how can I add a setting to not add or remove...
Read more >
Multiple semicolon-separated addresses no longer work in to ...
Multiple semicolon-separated addresses no longer work in to/cc/bcc fields, empty/null fields should be ignored (deprecated/invalid syntax Bug 242693).
Read more >
IDAX.LINEAR_REGRESSION build linear regression model
Use this stored procedure to build a linear regression model. ... of the input table that have specific properties, which are separated by...
Read more >
LINEST function - Microsoft Support
The LINEST function calculates the statistics for a line by using the "least squares" method to calculate a straight line that best fits...
Read more >
VS Code tips — JavaScript › Format: Semicolons - YouTube
Today's VS Code setting : javascript.format.semicolonsConfigure how the built-in JavaScript formatter handles semicolons :- ignore — Don't add ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found