Add targetNode to canDrag rule

I have a BoxListContainer and BoxListItem

The BoxListContainer is set to only accept BoxListItems

BoxListContainer.craft.rules.canMoveIn = incomingNode => incomingNode.data.type === BoxListItem

Now I need to also set that BoxListItem can be dragged only into BoxListContainer. How do I do that?

canDrag(currentNode: Node, helpers: NodeHelpers) => boolean
canMoveIn(incomingNode: Node, currentNode: Node, helpers: NodeHelpers) => boolean
canMoveout(outgoingNode: Node, currentNode: Node, helpers: NodeHelpers) => boolean

I am missing targetNode in canDrag, the other two have both nodes available.

this:

canDrag(currentNode: Node, targetNode: Node, helpers: NodeHelpers) => boolean

BoxListItem.craft.rules.canMoveIn = (_currentNode, targetNode) => targetNode.data.type === BoxListContainer

[prevwong]

It seems to me now that you’re interested in implementing a canDrop rule which is not related to the canDrag rule that you created this issue for. Hence, this whole misunderstanding is happening now.

But anyways, with that brief example of yours, a canDrop rule might make sense. I would be glad to review a PR for this.

If I were to import external component, which I don’t even have a control over

If you were to import an external component and you want to use as a <Canvas />, you will have to create a wrapper for it anyway in order for you to specify configuration for it.

p.s. Stop spamming the issues tracker. We can use Discord for more long-winded discussions such as this. It also doesn’t help that you occasionally post your questions/issues on both platforms.

[prevwong]

Isn’t this use case supported by canDrag already ? For example, let’s say we want our component to only be able to move out depending on the parent it is in:

canDrag: (node, helpers) => {
  const parent = helpers.get(node.parent);
  if ( parent.data.type == BoxListContainer ) return false;
  return true;
}

Currently, Craft depends on both the component’s canDrag and the target parent’s canMoveOut for the component to be successfully moved out, so I think this already does what you want, or am I missing something ?