question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Hotels FE is having an issue with <Text> not accepting a width prop for IE

See original GitHub issue

Describe the bug For IE we want to give the <Text> component a defined width because without it IE is not displaying it properly.

Screen Shot 2020-07-30 at 12 26 03 PM

Potential Solutions We could simply add a width prop to the Text component, or we could have the Text component be built on top of the Box component. Right now, Text is just a styled.div.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:10

github_iconTop GitHub Comments

1reaction
tfquirkcommented, Jul 31, 2020

@tfquirk Unless anyone is opposed, I think supporting width and related props on Text sounds like a great idea 😄

Awesome, I’ll give this time for anyone else to review this convo and weigh in as well. And then I will be happy to own the work to get it done.

0reactions
tfquirkcommented, Jul 31, 2020

I would say all of these could be up for discussion:

 display
 height
 maxHeight
 maxWidth
 minHeight
 minWidth
 width

And as you mentioned, @sdalonzo , this could be an option too: Screen Shot 2020-07-31 at 3 26 31 PM (screen shot is from styled system docs, not from our Box). We would need to verify that overflow is accessible on our current version of the styled system.

Read more comments on GitHub >

github_iconTop Results From Across the Web

vx/text width prop breaks w/ SSR #266 - airbnb/visx - GitHub
I'm not actually sure if this has anything to do with SSR, but the problem presents only on fresh page loads in my...
Read more >
Internet Explorer 11 word wrap is not working - Stack Overflow
I got here for a different problem where word-wrap wasn't working on IE11; The {width: 100%} solution did work for me. Save this...
Read more >
UWr - River Thames Conditions
Bananenchips maken surinaams, Tin tan revoltoso pelicula completa, Call ireland from france code, Cofanetto batman nolan, Cuisine juive tunisienne, ...
Read more >
2022-23 MSHSAA Official Handbook
In a) accepting those funds or having event fees paid would not be permissible. This would be a cash/cash equivalent.
Read more >
Lots of Ways to Use Math.random() in JavaScript - CSS-Tricks
This is incredibly useful for gaming, animations, randomized data, generative art, random text generation, and more!
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found