ColumnToggler: Label Issue on ColumnToggler

1) Environment

• PrimeFaces version: 7.0
• Does it work on the newest released PrimeFaces version? Version? NO
• Does it work on the newest sources in GitHub? (Build by source -> https://github.com/primefaces/primefaces/wiki/Building-From-Source) No
• Application server + version: All
• Affected browsers: All

2) Expected behavior

Only Label should be show in p:columnToggler

…

3) Actual behavior

OutputLabel value and Tooltip value are show in p:columnToggler

…

4) Steps to reproduce

Change code is showcase.

…

5) Sample XHTML

<p:column>
                <h:outputText value="#{car.id}" />
                <f:facet name="header">
		        <p:outputLabel value="ID" id="outputTextID"/>
			<p:tooltip value="Tooltip for ID" for="outputTextID"></p:tooltip>
		</f:facet>
</p:column>

…

6) Sample bean

NA …

[melloware]

@mertsincan I read your comment and I don’t see the problem? if a “label” is found in a header then that label is used for the toggler else it uses the detault. In your example where you have an Label, a Span, and a text it finds the label and uses that for the column. To me the column doesn’t make sense if your Column Toggler had “ID test test2” as the column title. The fact that you included a label means you want the label to be used specifically as the Column Toggler name.

And also since it was reported on 3 different tickets this is clearly an issue the community keeps running into that to me needs to be fixed.

[melloware]

@mertsincan A few things.

1. This fix just addressed the Column Toggler finding the “wrong” element and using it as a label. It seems a huge improvement in expected behavior. I have seen other comments about adding a custom style to find the right element for the label which is cool but a user would have to know to look in the documentation for that style. I am still OK with that but we should also leave my “find the first label” fix in.

2. As for the Showcase I am seeing the same thing in Chrome and Edge. If you click the button and click anywhere outside the button it works every time. But if you click the button to close it it won’t re-open without 2 clicks.