DatePicker: onchange event called twice using touchUI="true"

Describe the bug

When editing a cell with a datepicker in it, currentCell property returns null only on an iPhone This is due to on onchange event being called twice and resetting currentCell to null

This can also be reproduced on Safari (Mac/Desktop) Developer Tools by impersonating iPhone actual iPhone is not necessary.

Reproducer

See https://github.com/lprimak/apps/blob/f3afa201abe1250d543cdbe6ab2faaeb17566fa1/emailmanager/hope-website/testdatefield.xhtml#L37

Workaround:

onchange="var bt = PF('birthdayTable');
                    if (bt.currentCell) bt.saveCell(bt.currentCell)"

Expected behavior

onchange event would be called only once or currentCell would be non-null the second time on both iPhone and other browsers

PrimeFaces edition

Community

PrimeFaces version

12.0.0RC3, 12.0.0

Theme

Default

JSF implementation

Mojarra

JSF version

2.3

Java version

8 through 19

Browser(s)

Safari on iPhone

[melloware]

I have narrowed the bug down to this. When it switched from regular to touchUI mode the click events get registered twice.

updateResponsiveness: function() {
            if (this.options.autoDetectDisplay && this.options.responsiveBreakpoint && !this.options.inline) {
                var currentUI = this.options.touchUI;
                var newUi = PrimeFaces.env.mobile || PrimeFaces.env.isScreenSizeLessThan(this.options.responsiveBreakpoint);
                if (currentUI !== newUi) {
                    this.options.touchUI = newUi;
                    this._render();
                }
            }
        },

if I comment out this line they are only registered once but the wrong thing is happening.

 this._render();

So even though I am calling off before rebinding events the delegated click is still being registered.

 this.panel.off('click.datePicker-date', dateSelector).on('click.datePicker-date', dateSelector, null, function (event) {

[melloware]

I fixed the NULL check in saveCell but still haven’t found a solution for the double mapping of click events.