DatePicker: pattern messed with LocalDateTime and showTime="true"

1) Environment

• PrimeFaces version: trunk
• Application server + version: jetty 9.20
• Affected browsers: all

2) Expected behavior

The user-provided pattern is not modified.

3) Actual behavior

HH:mm is added to the pattern, causing conversion errors.

4) Steps to reproduce

…

5) Sample XHTML

<h:form>
	<div>
		<p:outputLabel for="date1" value="Date1" style="display: inline-block; width: 120px;"/>
		<p:datePicker id="date1" value="#{testViewCdi.date1}" showTime="true"/>
		<p:message for="date1"/>
	</div>
	<div>
		<p:outputLabel for="date2" value="Date2" style="display: inline-block; width: 120px;"/>
		<p:datePicker id="date2" value="#{testViewCdi.date2}" showTime="true" pattern="dd/MM/yy HH:mm"/>
		<p:message for="date2"/>
	</div>
	<div>
		<p:outputLabel for="date3" value="Date3" style="display: inline-block; width: 120px;"/>
		<p:datePicker id="date3" value="#{testViewCdi.date3}"/>
		<p:message for="date3"/>
	</div>
	<div>
		<p:outputLabel for="date4" value="Date4" style="display: inline-block; width: 120px;"/>
		<p:datePicker id="date4" value="#{testViewCdi.date4}" pattern="dd/MM/yy"/>
		<p:message for="date4"/>
	</div>
	<p:commandButton id="sub" value="submit" update="@form"/>
</h:form>

6) Sample bean

@Named
@ViewScoped
public class TestViewCdi implements java.io.Serializable {

	private java.time.LocalDateTime date1 = java.time.LocalDateTime.now();

	private java.time.LocalDateTime date2 = java.time.LocalDateTime.now();

	private java.time.LocalDateTime date3 = java.time.LocalDateTime.now();

	private java.time.LocalDateTime date4 = java.time.LocalDateTime.now();

	// getters and setters
}

[NicolaIsotta]

IMHO the easiest and best solution is the server-side only:

1. If the user provides a pattern and if the pattern contains a time part, remove the part
2. This “cleaned” pattern will be passed by the widget builder
3. if showTime is true, generate a time pattern from the datepicker attributes (hourFormat and showSeconds)
4. Combine the “clean” pattern and the generated time pattern to create a “full” pattern. This one will be used to convert the value

[NicolaIsotta]

PR: #5313