Dialog fitViewport doesn't work in pf 10.0.0

Describe the defect dialog.js function fitViewport, please change the row this.content.css('max-height', String(maxHeight)); to this.content.css('max-height', maxHeight);. String constant for max-height without units doesn’t work in jquery 3.5.1 which is used in PF 10.0.0. In jquery 3.6.0 it works fine.

Environment:

• PF Version: 10.0.0

[melloware]

@vonnai can you try this and verify it works… Just add this script to your application.

if (PrimeFaces.widget.Dialog) {
    PrimeFaces.widget.Dialog.prototype.fitViewport = function() {
        var windowHeight = $(window).height();
        var margin = this.jq.outerHeight(true) - this.jq.outerHeight();
        var headerHeight = this.titlebar.outerHeight(true);
        var contentPadding = this.content.innerHeight() - this.content.height();
        var footerHeight = this.footer.outerHeight(true) || 0;
        var maxHeight = windowHeight - (margin + headerHeight + contentPadding + footerHeight);
        this.content.css('max-height', maxHeight + 'px');
    }
}

[VsevolodGolovanov]

Not sure why you’re scripting at all here. Could just style smth like max-height: calc(100vh - 50px);. This should work even in IE9. I’d remove the fitViewport option and just have it like this by default. Then if someone really needs an overflowing dialog they could just override max-height by styling.