Password: Html validation errors (aria-readonly, role)

Describe the defect I’m currently working on a project which was recently tested for valid html code. Among other components, we use the Primefaces password component which causes some errors when validating the html which is displayed in the browser. I have also tested it via primefaces-test for the 9.0-SNAPSHOT version, but the errors still exists.

The password field in the resulting html shows up with both “role=‘textbox’” and “aria-readonly=‘false’” attributes, which both cause error messages. Both of these attributes are set in the “core.js” -> “skinInput()” method.

Validation errors:

1. “Attribute role not allowed on element input at this point.”
2. “Attribute aria-readonly not allowed on element input at this point.”

Environment:

• PF Version: 9.0-SNAPSHOT
• JSF + version: Mojarra 2.3.14
• Affected browsers: ALL

To Reproduce Steps to reproduce the behavior:

1. Go to e.g. ‘http://localhost:8080/primefaces-test/’
2. Open e.g. Nu Html Checker
3. See error

Example XHTML Input

<p:password id="password-test" value="test"/>

Result

<input id="frmTest:password-test" name="frmTest:password-test" type="password" class="ui-inputfield …i-widget ui-state-default ui-corner-all" role="textbox" aria-disabled="false" aria-readonly="false">

[melloware]

OK I fixed it master to leave aria-disabled.

[melloware]

AHh OK let me make disabled OK.