p:repeat: fix Mojarra ui:repeat does not reset EL var correctly

Describe the defect The “resetValues=true” attribute + UIRepeat behave not as expected (please check the attached application and the code snippet below)

Reproducer primefaces-test application is attached primefaces-test-master.zip

Environment:

• PF Version: 10.0.0
• JSF + version: Mojarra (all versions)
• Affected browsers: ALL_

To Reproduce Steps to reproduce the behavior:

1. Go to the index page on attached primefaces-test application
2. Click on ‘Reproduce bug’ link

Expected behavior I expect the variable #{value} stay empty

Example XHTML

    <h:form>
        Expected to stay empty: #{value}
    </h:form>
    <h:form>
        <ui:repeat value="#{testView.strings}" var="value">
            <p:outputLabel value="#{value} "/>
        </ui:repeat>
    </h:form>

    <h:form>
        <!-- this link will update the variable value in the first form with value from the UIRepeat -->
        <p:commandLink value="Reproduce bug" process="@this" update="@(form)" resetValues="true"/>
        <!-- and this link works fine -->
        <p:commandLink value="Not reproduce bug" process="@this" update="@(form)" resetValues="false"/>
    </h:form>

Example Bean

@Data
@Named
@ViewScoped
public class TestView implements Serializable {
    
    private final List<String> strings = new ArrayList<>();

    @PostConstruct  
    public void init() {
        strings.addAll(Arrays.asList("Winona Lindsey", "Pandora Peay", "Honey Dean"));
    }

    public List<String> getStrings() {
        return strings;
    }
}

[arjantijms]

I am most dissapointed with Mojarra progress since switching from Oracle to Jakarta.

I am actually somewhat disappointed myself too 😦 From being one of the many contributors to Mojarra, I’m suddenly pretty much the only one. If you want I can nominate you though to become committer, so it’s not essentially me who’s the bottleneck. Let me know if interested.

Btw, on the issue of resetting EL vars in general, almost a decade ago I also created issues for this, but with Mojarra and with PrimeFaces. If I remember correctly Cagatay responded that he would mediate over it. The idea I proposed was creating a kind of internal “scope” (not a true scope), which would clear out EL variables local to a component automatically.

[rabiter]

the Mojarra UIRepeat issue seems to be at least 8 years old: https://stackoverflow.com/questions/14398960/magic-uirepeat-var