Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

TreeTable: CellEdit event not working for dynamic columns

See original GitHub issue

I retested https://github.com/primefaces/primefaces/issues/4724. successfully with 8.0-SNAPSHOT for p:dataTable. However, p:treeTable does not work. Here is the sample for p:treeTable:

Bean3.java

@SessionScoped @Named
public class Bean3 implements Serializable {
  private static final long serialVersionUID = 1L;

  public class Test implements Serializable { // Content class of TreeNodes
    private static final long serialVersionUID = 1L;	
    public String value;
    public String getValue() { return value; }
    public void setValue(String value) { this.value = value; }

    public int index;
    public int getIndex() { return index; }
    public void setIndex(int index) { this.index = index; }
		
    public Test(String value, int index) { this.value=value; this.index=index; }
  }
	
  TreeNode root;
  public TreeNode getRoot() { return root; }
  public void setRoot(TreeNode root) { this.root = root; }

  public void createTreeNodes() { 
    root=new DefaultTreeNode(new Test("Root", 0), null);
	new DefaultTreeNode(new Test("One", 1), root);
	new DefaultTreeNode(new Test("Two", 2), root);
  }
  @PostConstruct public void init() { createTreeNodes(); }
	
  public void onCellEdit(CellEditEvent<?> e) { info("cellEdit", e); }
  public void onCellEditInit(CellEditEvent<?> e) { info("cellEditInit", e); }
  public void onCellEditCancel(CellEditEvent<?> e) { info("cellEditCancel", e); }
	
  public static void info(String method, CellEditEvent<?> e) {
    String message=String.format("old=%s, new=%s", e.getOldValue(), e.getNewValue());
    FacesContext.getCurrentInstance().addMessage(null, 
      new FacesMessage(FacesMessage.SEVERITY_INFO, method+":", message));
  }
}

treeTable.xhtml

<html xmlns="http://www.w3.org/1999/xhtml" xmlns:h="http://java.sun.com/jsf/html"
   xmlns:f="http://xmlns.jcp.org/jsf/core" xmlns:p="http://primefaces.org/ui" >
<h:head />
<h:body>
  <h:form id="form">
    <p:growl id="msgs" showDetail="true"/>
    <p:treeTable value="#{bean3.root}" var="var" editMode="cell" editable="true" tableStyle="width:auto">
      <p:ajax event="cellEditInit" listener="#{bean3.onCellEditInit}" update=":form:msgs"/>
      <p:ajax event="cellEdit" listener="#{bean3.onCellEdit}"  update=":form:msgs"/>
      <p:columns var="property" value="#{['value','index']}"  headerText ="#{property}">
        <p:cellEditor>
          <f:facet name="output"><h:outputText value="#{var[property]}" /></f:facet>
          <f:facet name="input"><p:inputText value="#{var[property]}" /></f:facet>
        </p:cellEditor>
      </p:columns>
    </p:treeTable>
  </h:form>
</h:body>
</html>

Reproduce

Click in the top/left cell and change the value. It will not change (bug).
- The message shows cellEdit: old=One, new=One, but new should be changed.
- Also, cellEditInit is not fired for treeTable (but for dataTable)
Hovever, in the second row, it works

Issue Analytics

State:
Created 4 years ago
Comments:13 (10 by maintainers)

Top GitHub Comments

1reaction

mellowarecommented, Mar 4, 2020

OK I merged the CellEditInit event fix but reopened this ticket since the CellEdit issue is not resolved.

1reaction

mellowarecommented, Mar 4, 2020

So I fixed the treetable CellEditInit event issue. But still working on the CellEdit event. It is so werid it only happens on the first cell but row 2 it works fine.