Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
Buttons have incorrect sizes
See original GitHub issueDescribe the bug While documenting https://github.com/github/primer/issues/263, I realized that Primer React buttons have incorrect sizes when compared to Figma references and Primer CSS implementation, usually being 2px taller than expected.
This issue is probably due to borders being ignored in the calculation after specifying line-height + padding.
The total height of regular buttons should be 32px on the medium size, 28px on the small size, and 40px on the large size.
Related
https://github.com/github/primer/issues/41 (on “Using borders”)
Issue Analytics
- State:
- Created 2 years ago
- Comments:5 (2 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
Also the icon sizes don’t correlate to the expected button sizes. So I’m assuming we don’t change the size of icons for buttons which have them.
https://github.com/primer/octicons/blob/main/docs/content/packages/react.mdx#sizes
This is all fixed. Is the fix ideal? Maybe not. But the issue doesn’t exist any more with the new Button component