Make clear ActionList.Item's `trailingIcon` can be a component

The component props of ActionList.Item suggest that trailingIcon can be either an icon or similar.

  /**
   * Icon (or similar) positioned after `Item` text.
   */
  trailingIcon?: React.FunctionComponent<IconProps>

Would a Label be considered appropriate usage for this? If so, should we update props to allow more generic usage?

In addition to this, leadingVisual has the same definition but it’s name (“Visual”) suggest a more generic usage, I’m wondering if this differentiation in name is still appropriate.

  /**
   * Icon (or similar) positioned before `Item` text.
   */
  leadingVisual?: React.FunctionComponent<IconProps>

In effect, this is what I’m envisioning:

[six7]

We could adopt trailingVisual for the right-aligned component, making it obvious that side area can be used for more components than just icons. That’s also how we refer to it in the design docs, even though they are not exactly the same as leadingVisual in terms of behavior (one being always in a square container, the other supporting flexible widths).

👍 to trailingVisual for consistency with existing docs and other props. Also, we’re currently treating that prop with IconProps - I think we should update that as well to reflect a more generic usage?

[siddharthkp]

Implemented in https://github.com/primer/react/pull/1521 / v31.0.1 😃