Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Support right alignment in SelectMenu

See original GitHub issue

The SelectMenu in Primer CSS supports aligning the modal with the button: https://primer.style/css/components/select-menu#right-aligned

We should add a corresponding prop to SelectMenu.Modal and possibly provide an example showing how to do so.

Issue Analytics

State:
Created 3 years ago
Comments:6 (6 by maintainers)

Top GitHub Comments

2reactions

BinaryMusecommented, May 5, 2020

I think the only strong opinion I have is to not use any more alignRight style booleans, unless it really is a boolean state (like hidden). align or variant can be expanded easily, alignRight can’t.

1reaction

dmarceycommented, May 5, 2020

It looks like Tooltip uses align?: 'left' | 'right', UnderlineNav uses align?: 'right' (just right? maybe a TS bug?), and AvatarStack uses alignRight?: boolean.

I couldn’t find an example where variant was used to handle alignment, but it doesn’t seem too far-fetched.

In light of these examples, I think I’ll give a shot at align?: 'left' | 'right' which defaults to 'left' and we can see how that looks in the PR.

Thanks @BinaryMuse !