TabNav cannot be properly assigned `roles`
See original GitHub issueDescribe the bug
When using a <TabNav />
, no tablist
and tab
roles are assigned directly.
Due to the implementation, attempting to provide this manually creates invalid aria role semantics, since the rest props of TabNav are applied to the wrapper and not the ‘nav’ element, while the link roles are applied directly
current jsx => Markup
<TabNav role="tablist"><TabNav.Link role="tab /></TabNav>
=>
<div role="tablist"><nav><a role="tab /></nav></div>
expected
<TabNav role="tablist"><TabNav.Link role="tab /></TabNav>
=>
<div><nav role="tablist"><a role="tab /></nav></div>
or that these are applied by default?
Issue Analytics
- State:
- Created 2 years ago
- Comments:7 (5 by maintainers)
Top Results From Across the Web
Portal: Tab displayed but not assigned to any roles of user
When I logon portal as a specific user, there are 5 tab in home page. When I check the role list, 3 tabs...
Read more >Tab nav bar navigation to dissabled · Issue #10354 - GitHub
Having a mat-tab-nav-bar with a disabled link, one can still navigate to the disabled page. ... crisbeto self-assigned this on Mar 10, 2018....
Read more >Users in Custom Role cannot access Page Tab and Page ...
Go to Administration -> Backend Pages click "OK, Continue". Navigate to Sitefinity->Design->Templates where you will see the Page Templates ...
Read more >can't render the products in proper order using nested map ...
I'm trying to build a restaurant web-app with Reactjs. I've parent categories, child categories, and products under child categories, ...
Read more >Marine Officer MOS Assignment Handbook - Training Command
Each one of the 26 Marine Officer PMOSs requires a diverse array of well-educated and skilled leaders that exemplify a warrior spirit.
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
@lesliecdubs I believe this one is done!
Got it, we’ll work on getting that out this week. I’m assigning this issue to you in the meantime, but if that’s incorrect please feel free to unassign. Thanks for moving this forward!