Consider replacing `rejectOnNotFound`

Problem

Right now there’s two ways to use rejectOnNotFound:

1. Globally

const prisma = new PrismaClient({
  rejectOnNotFound: true,
})

const prisma = new PrismaClient({
  rejectOnNotFound: {
    findFirst: {
      User: (err) => new Error('User error'),
      Post: (err) => new Error('Post error!'),
    },
    findUnique: {
      User: (err) => new Error('User error'),
      Post: (err) => new Error('Post error!'),
    },
  },
})

2. Locally

const result = await prisma.user.findUnique({
  where: {
    id: 42,
  },
  rejectOnNotFound: true
})

The problem with the global one is that you’d want to change the return type for the models you decide to reject. Instead of User | null, it should be User, since it’s going to reject not found users anyway.

Open Question: does local rejectOnNotFound adjust the signature?

Suggested solution

My vote would be to remove this API and replace it with a few new methods:

• prisma.user.mustFindUnique()
• prisma.user.mustFindFirst()

Then everything is explicit, local and the return types can be properly altered.

Alternatives

I’m guessing our engineers have thought of other solutions 😃

Additional context

• Entgo does something similar with Save and SaveX

[zomars]

I think it’s Prisma.notFound

.catch((e) => { if (e instanceof Prisma.notFound) { throw new HttpError({ statusCode: 404, message: "User not found" }); } });

The thing is the throw new HttpError won’t be respected globally unless this has been fixed already.

EDIT: seems like global errors have been deprecated

[agustif]

I think it’s Prisma.notFound

.catch((e) => { if (e instanceof Prisma.notFound) { throw new HttpError({ statusCode: 404, message: "User not found" }); } });