No validation error on 1:m ambiguous relation

Hi Prisma Team! My Prisma Client just crashed. This is the report:

Versions

Name	Version
Node	v10.20.1
OS	darwin
Prisma	2.5.1

Logs

  prisma-client { engineConfig:
  prisma-client    { cwd: '/Users/user/project/prisma',
  prisma-client      enableDebugLogs: false,
  prisma-client      enableEngineDebugMode: undefined,
  prisma-client      datamodelPath:
  prisma-client       '/Users/project/node_modules/.prisma/client/schema.prisma',
  prisma-client      prismaPath: undefined,
  prisma-client      engineEndpoint: undefined,
  prisma-client      generator:
  prisma-client       { name: 'client',
  prisma-client         provider: 'prisma-client-js',
  prisma-client         output:
  prisma-client          '/Users/project/node_modules/@prisma/client',
  prisma-client         binaryTargets: [],
  prisma-client         previewFeatures: [],
  prisma-client         config: {} },
  prisma-client      showColors: false,
  prisma-client      logLevel: 'info',
  prisma-client      logQueries: true,
  prisma-client      flags: [],
  prisma-client      clientVersion: '2.5.1',
  prisma-client      enableExperimental: [],
  prisma-client      useUds: undefined } }  
  plusX Execution permissions of /Users/project/artemis/node_modules/.prisma/client/query-engine-darwin are fine  
  prisma-client Client Version 2.5.1  +29s
  prisma-client Engine Version 9a670138b1db276001d785a2adcba1584c869d24  

Prisma.schema

model AuthorBook {
  authorId            Int  
  booksId            String

  author         Author @relation(fields: [authorId], references: [id])
  books          Book  @relation(fields: [bookId], references: [id])

  @@id([authorId, bookId])
  @@map("author_book")
}
model Author {
  id            Int  
  name            String

  books       Book[]

  @@map("author")
}
model Book {
  id            Int  
  title            String
  description    String

  authors       Author[]

  @@map("book")
}

TS file

const books = await prisma.authorBook.findMany({
        where: {
          authorId: `${author.id}`,
        },
        include: {
          book: true,
        },
      });

The above is an abstracted example of how I’m trying to call this.

[pantharshit00]

Looks like query engine doesn’t panic with the schema in latest version anymore.

But migrate now tries to add two foreign keys with above schema:

CREATE TABLE "codes" (
    "id" TEXT NOT NULL,
    "type" TEXT NOT NULL,
    "singleUse" BOOLEAN NOT NULL,
    "userId" TEXT,
    "createdById" TEXT,
    "userId" TEXT,

    PRIMARY KEY ("id")
);

-- CreateTable
CREATE TABLE "users" (
    "id" TEXT NOT NULL,
    "name" TEXT,

    PRIMARY KEY ("id")
);

-- AddForeignKey
ALTER TABLE "codes" ADD FOREIGN KEY ("userId", "userId") REFERENCES "users"("id") ON DELETE SET NULL ON UPDATE CASCADE;

-- AddForeignKey
ALTER TABLE "codes" ADD FOREIGN KEY ("userId", "userId") REFERENCES "users"("id") ON DELETE SET NULL ON UPDATE CASCADE;

So moving this to the migrate team now.

[do4gr]

This should be solved by us splitting the parsing and formatting step here https://github.com/prisma/prisma-engines/pull/1662