Reduce the number of generated SQL statements for Updates/Inserts

I’m not sure if there is a good reason for how it currently works, but it looks like you could reduce the number of SQL statements generated for update.

Problem

The following code:

  const updatedPost = await prisma.post.update({
    where: {
      id: 1,
    },
    data: {
      published: true,
    },
  });

Generates this SQL:

prisma:query BEGIN
prisma:query SELECT `dev`.`Post`.`id` FROM `dev`.`Post` WHERE `dev`.`Post`.`id` = ?
prisma:query UPDATE `dev`.`Post` SET `published` = ? WHERE `dev`.`Post`.`id` IN (?)
prisma:query SELECT `dev`.`Post`.`id`, `dev`.`Post`.`title`, `dev`.`Post`.`content`, `dev`.`Post`.`published`, `dev`.`Post`.`authorId` FROM `dev`.`Post` WHERE `dev`.`Post`.`id` = ? LIMIT ? OFFSET ?
prisma:query COMMIT

Solution

In PostgreSQL, I would normally write this as:

update `dev`.`Post` set published = ? where id = ? returning *

Additional context

You could use returning on inserts too.

[aradalvand]

No updates on this one yet? It’s now been more than 2 years… 😦

[Sytten]

This is a recurring demand from the community, but as the devs said many times the first goal of the beta is to get things working correctly then optimize. There are many open issues for optimization. This one seems a duplicate of https://github.com/prisma/prisma/issues/2157.