$transaction doesn't roll back in NestJS when we pass method from external service

Bug description

$transaction works incorrectly in NestJS when we pass method from external service, but works well if it uses method from current service. It doesn’t roll back as expected.

Example:

// UserService
@Injectable()
export class UserService {
  constructor(private readonly prismaService: PrismaService) {}

  addMoney(userId: number, value: number) {
    return this.prismaService.user.update({
      where: { id: userId },
      data: {
        money: {
          increment: value,
        },
      },
    });
  }
}

// InventoryService
@Injectable()
export class InventoryService {
  constructor(
    private readonly prismaService: PrismaService,
    private readonly userService: UserService,
  ) {}

  async sell(userId: number, itemId: number) {
    const write1 = this.prismaService.userItem.delete({
      where: { ... },
    });

    // external service method
    const write2 = this.userService.addMoney(...);

    await this.prismaService.$transaction([write1, write2]);
  }

  addMoney(userId: number, value: number) {
    return this.prismaService.user.update({
      where: { id: userId },
      data: {
        money: {
          increment: value,
        },
      },
    });
  }
}

If write2 will fail - write1 doesn’t rollback. But… rollback will work as expected if write2 refers to the current service method. (this.addMoney)

How to reproduce

https://github.com/revivalme/nestjs-prisma-transaction-test Bug reproduction section

Expected behavior

Transaction write1 should rollback as transaction write2 failed.

Prisma information

Environment & setup

• OS: Windows 10
• Database: SQLite, PostgreSQL
• Node.js version: v14.15.4
• Prisma version:

prisma               : 2.17.0
@prisma/client       : 2.17.0
Current platform     : windows
Query Engine         : query-engine 3c463ebd78b1d21d8fdacdd27899e280cf686223 (at node_modules\@prisma\engines\query-engine-windows.exe)
Migration Engine     : migration-engine-cli 3c463ebd78b1d21d8fdacdd27899e280cf686223 (at node_modules\@prisma\engines\migration-engine-windows.exe)
Introspection Engine : introspection-core 3c463ebd78b1d21d8fdacdd27899e280cf686223 (at node_modules\@prisma\engines\introspection-engine-windows.exe)
Format Binary        : prisma-fmt 3c463ebd78b1d21d8fdacdd27899e280cf686223 (at node_modules\@prisma\engines\prisma-fmt-windows.exe)
Studio               : 0.353.0

Conversation from Public Slack here

[timsuchanek]

Thanks @revivalme for the report. We’ll have a look at this!

[williamluke4]

Hey @revivalme, I’m going to close this issue, if you feel like the problems you are experiencing are still related to this specific issue then feel free to reopen it explaining why.