upsert across HTTP requests has a race condition

Bug description

Situation: I have a model with a unique string. At the beginning I have an empty database. I want to create or update an object of the model with upsert and check if the object exists by searching for the unique string.

If I call several upserts with the same unique string at the same time, I expect it to be created once and then updated if necessary. But it is created once and then the error occurs: Unique constraint failed on the fields.

Unique constraint failed on the fields: (`testId`).

How to reproduce

Expected behavior

I expect it to be created once and then updated the just created object, instead of crashing.

Prisma information

model Test {
  id Int      @default(autoincrement()) @id
  testId     String   @unique
}
const prismaClient = new PrismaClient({
  log: ["info", "warn", "error"],
});

const upsertPromises: Promise<Test>[] = [];
for (let i = 0; i < 2; i++) {
  upsertPromises.push(
    prismaClient.test.upsert({
      where: { testId: "testId" },
      create: {
        testId: "testId",
      },
      update: {},
    })
  );
}
await Promise.all(upsertPromises);

Environment & setup

• OS: Mac OS,
• Database: PostgreSQL
• Node.js version: v13.3.0
• Prisma version: 2.3.0

[windowsdeveloperwannabe]

Should Prisma’s upsert not being a real upsert be highlighted by the documentation? Or alternatively the method renamed to create_or_update like in ActiveRecord. 🤔 It is quite the blocker when you start getting unique constraint errors from simple upserts.

Prisma’s data guide pages even describe the real upsert so Google results can get quite confusing.

[bartoszhernas]

Who though that doing completely opposite what the DataGuide recommends is a good choice?

I understand rationale for supporting other mechanism that do not support native UPSERT, but then just make it clear in Docs, and underneath use whatever is best suited for each type of DB. You are using ForeignKeys in Postgres, even though MongoDB doesn’t have it right?

Prisma’s Data Guide Learn how databases work, how to choose the right one, and how to use databases with your applications to their full potential.

Ok, so let me learn, but then do NOT allow me to use the full potential of the DB, at the same time misleading me of what upsert does (dataguide says to use prisma’s upsert as example of how to use postgre’s UPSERT, which is a lie). What gives? You are teaching people to do X, and at the same time you do not do the X. You even make it hard/impossible to do the correct thing while using Prisma 😦