Cannot override bot.findBlock

Greetings,

I just installed https://github.com/Darthfett/mineflayer-blockFinder and after debugging my project I noticed that its implementation is always ignored in favor of the one in mineflayer.

Here’s some code snippets:

My project’s code:

var bot = mineflayer.createBot({
...
});

// Install the plugin - method override is done here
blockFinderPlugin(bot);

// Sample usage
bot.once('spawn', function() {
  bot.findBlock(...) // the original findBlock is called instead of the plugin`s
});

The injection function blockFinderPlugin is successfully called and the override code also succeeds:

        function findBlockSync(options) {
...
        }

        function findBlock(options, callback) {
...
        }

        bot.findBlock = findBlock;
        bot.findBlockSync = findBlockSync;  

Yet the original function is always called instead. I don’t know if the issue belongs here or at the plugin dev’s repo, so apologies if this isn’t meant for here.

Cheers

[rom1504]

Ah yes, this is due to the new version system which guess the version and load the plugin afterwards. That should be fixed somehow

On Fri, Jun 23, 2017, 18:56 ViR Dash [e-mail] wrote:

Greetings,

I just installed https://github.com/Darthfett/mineflayer-blockFinder http://mineflayer-blockFinder and after debugging my project I noticed that its implementation is always ignored in favor of the one in mineflayer.

Here’s some code snippets:

My project’s code:

var bot = mineflayer.createBot({ … });

// Install the plugin - method override is done here blockFinderPlugin(bot);

// Sample usage bot.once(‘spawn’, function() { bot.findBlock(…) // the original findBlock is called instead of the plugin`s });

The injection function blockFinderPlugin is successfully called and the override code also succeeds:

    function findBlockSync(options) {

… }

    function findBlock(options, callback) {

… }

    bot.findBlock = findBlock;
    bot.findBlockSync = findBlockSync;

Yet the original function is always called instead. I don’t know if the issue belongs here or at the plugin dev’s repo, so apologies if this isn’t meant for here.

Cheers

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/PrismarineJS/mineflayer/issues/539, or mute the thread https://github.com/notifications/unsubscribe-auth/ACPN_h039POG-xwICrOpJsuw4Tl4hmTfks5sG-42gaJpZM4ODzwz .

[rom1504]

now fixed, have a look at https://github.com/Darthfett/mineflayer-blockfinder/pull/16