Refactoring Client to extend Stream.

I think client should be build on top of a stream.

so you can do client.pipe(fs.createWriteStream('protocol.log'))

client.pipe(new Transform({ writableObjectMode: true, transform(chunk, enc, cb) {
  this.push(JSON.stringify(chunk,null,2);
  cb();
}})).pipe(fs.createWriteStream('protocol.log'));

stream -> [ serializer ] -> [ compressor ] -> framer -> [ cipher ] -> socket socket -> [ decipher ] -> splitter -> [ decompressor ] -> deseralizer -> stream

[rom1504]

Ah now I see @roblabla point. Yes you still won’t be able to do

client.pipe(fs.createWriteStream('protocol.log'))

directly.

But you will be able to do

client.pipe(new Transform({writableObjectMode: true,transform(chunk,enc,cb){this.push(JSON.stringify(chunk,null,2);cb();}})).pipe(fs.createWriteStream('protocol.log'))

[rom1504]

well the serializer readable part is object mode https://github.com/ProtoDef-io/node-protodef/blob/master/src/serializer.js#L5 I don’t think that’s a problem.

The difference between the deserializer and your “stream” is only that that “stream” would handle all the states, hence the user of the stream wouldn’t need to care about states.

That just means piping and unpiping the serializer and deserializer to that stream on change of state.

I guess we could then just listen on data of that stream to emit packet event, and write on that stream instead of writing directly on the serializer (for nmp client and server implementation). And expose the stream for people that want to use it directly.