context.config doesn’t work with config root is an array

Bug Report

A *.yml file can return an Array, just like JSON. The problem is that we implement the defaulting of configuration using Object.assign() which doesn’t work with arrays too well, it turns an array into an object

https://github.com/probot/probot/blob/dee76d207b0fc35be9ae394d9e0602351d7c9701/src/context.ts#L127-L145

Besides Object.assign does only default on the top level, not deeply. I’d recommend to use _.defaultsDeep instead.

In my particular case I want to implement configuration as described at https://github.com/wip/app/issues/96#issuecomment-397750538

When .github/wip.yml looks like this:

- terms:
   - hold
 locations:
   - label
- terms:
   - fixup!
   - squash!
 locations:
   - commits

and I load the config like this

const config = await context.config('wip.yml')

Current Behavior

config is an object with two keys: {1: {...}, 2: {...}}

Expected behavior/code

config should be an array with two items: [{terms, locations}, {terms, locations}]

[BPScott]

Would be solved by #619

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.