context.payload is any again with typescript ?

Bug Report

Current Behavior

It seems payload is any again, like described in the issue https://github.com/probot/probot/issues/1366, with the latest release (I replied it worked, but now I’m not sure it did, as I am still migrating and have a lot of typescript errors)

// Your code here
module.exports = (app) => {
  app.on(
    'repository.edited',
    async (context) => {
      // context.payload is any
      // context is: (parameter) context: WebhookEvent<EventPayloads.WebhookPayloadRepository> & Context<any>
    };
  );

Expected behavior/code A clear and concise description of what you expected to happen (or code).

Environment

• Probot version(s): v10.9.4
• Node/npm version: Node 14 / Yarn 1.22.5
• OS: Ubuntu
• Typescript: 4.0.3

Possible Solution

I tried to change node_modules/probot/lib/types.d.ts :

-export declare type ProbotWebhooks = Webhooks<WebhookEvent, Context>;
+export declare type ProbotWebhooks = Webhooks<WebhookEvent, Omit<Context, keyof WebhookEvent>>;

And it seems to work: context is now:

(parameter) context: WebhookEvent<EventPayloads.WebhookPayloadRepository> & Pick<Context<any>, "github" | "log" | "event" | "repo" | "issue" | "pullRequest" | "isBot" | "config">

I could make a PR, but should we add a test somehow to make sure it will keep working ?

[gr2m]

Ahhh sorry Christophe, now I get it! Okay in this case feel free to add both a test and a fix to Probot. If it works well we can adopt a similar test for @octokit/webhooks to avoid future regressions

[github-actions[bot]]

🎉 This issue has been resolved in version 10.10.1 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀