question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Escape quotes in manifest creation

See original GitHub issue

Bug Report

Current Behavior If you use single or double in for example the description of a new probot during scaffolding, it seems to “break” the manifest, because these are not escaped, and therefor not valid JSON upon installing.

How to reproduce $ yarn create probot-app fooscreenshot 2018-10-09 at 21 12 47 etc.

Now try to install the app, and GitHub will tell you that it is not valid JSON (which is true).

Expected behavior/code I expect to be able to use single and double quotes unless “told” otherwise 😃

Environment

  • Probot version(s): 7.2.0
  • Node/npm/yarn version: Node 10.0/NPM 5.6/Yarn 1.9.4
  • OS: macOS 10.14

Possible Solution Either escape or somehow else serialize user input or only allow certain types of characters.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:13 (9 by maintainers)

github_iconTop GitHub Comments

2reactions
hiimbexcommented, Oct 18, 2018

Ahh, I honestly haven’t seen that come up and I’d prefer the manifest to work, so let’s move to escaping all the template variables!

1reaction
gr2mcommented, Jan 20, 2020

Could you please create a new issue for it and we take it from there?

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to escape double and single quotes in YAML within ...
So you should first decide what the output should be exactly, then if you need to escape any characters with backslash. If you...
Read more >
Chart Development Tips and Tricks
Covers some of the tips and tricks Helm chart developers have learned while building production-quality charts.
Read more >
Data format parameters - Amazon Redshift
When the quotation mark character is used within a field, escape the character with an additional quotation mark character. For example, if the...
Read more >
CREATE EXTERNAL TABLE - Amazon Redshift
You can use UTF-8 multibyte characters up to a maximum of four bytes. ... To reference files created using UNLOAD, you can use...
Read more >
Chapter 4: Scripting Reference
Quotes only have the property of containing a parameter if they surround the rest of the parameter. They can be either single quotes,...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found