Feedback on GraphQL support

#472 introduced GraphQL support through context.github.query. It’ll likely take a while to figure out patterns for efficiently building Probot apps with GraphQL. Your feedback is an important part of that. Feel free to comment here with ideas, friction, or suggestions on how we can make building Probot apps with GraphQL an amazing experience.

[jeffrafter]

This pattern is working really well for me… except when it doesn’t. I’ve noticed that some objects have “odd” html_url. One example is PullRequestReview:

https://github.com/<owner>/<repo>/pull/28#pullrequestreview-110303313

The fragment identifier is ignored when looking up the resource id, so you instead get the PullRequest global ID. I considered manually constructing the IDs (they are just Base64), but the version is volatile, I think.

Instead I fetched the PullRequestReview id by looking it up:

let issue = context.issue()
let reviewResponses = await getPullRequestReviews(context, issue.owner, issue.repo, issue.number)
let reviews = reviewResponses.repository.pullRequest.reviews.nodes

 // ...

let getPullRequestReviews = async (context, owner, name, number) => {
  const pullRequestReviewsQuery = `
    query getPullRequestReviews($owner: String!, $name: String!, $number: Int!) {
      repository(owner: $owner, name: $name) {
        pullRequest(number: $number) {
          reviews(first: 5) {
            nodes {
              id
              url
              viewerDidAuthor
            }
          }
        }
      }
    }`
  let response = await context.github.query(pullRequestReviewsQuery, {owner, name, number})
  return await response  
}

I only grab the first 5 as that is enough for me. You could subsequently loop through those to find the matching one.

<div> GitHub</div><div>Build software better, together</div><div>GitHub is where people build software. More than 27 million people use GitHub to discover, fork, and contribute to over 80 million projects.</div>

[maticzav]

Maybe you could add support for graphql-bindings, I genuinely enjoy using these in my other GraphQL projects. And there’s already an existing one made especially for Github! 🎉